When Singapore announced this week it would end a colonial-era law that criminalized sex between men, it looked like a big victory for gay rights advocates in the Southeast Asian country.